[Variant] ReadOnlyMetadataBuilder borrows its underlying VariantMetadata#8502
Merged
mbrobbel merged 2 commits intoapache:mainfrom Sep 30, 2025
Merged
[Variant] ReadOnlyMetadataBuilder borrows its underlying VariantMetadata#8502mbrobbel merged 2 commits intoapache:mainfrom
mbrobbel merged 2 commits intoapache:mainfrom
Conversation
Contributor
Author
|
CC @alamb -- should be a quickie, assuming you agree with the premise. |
scovich
force-pushed
the
read-only-metadata-references
branch
from
8b4fe52 to
d3590bb
Compare
Contributor
Author
|
Upstream conflicts resolved, should be ready for merge now. |
mbrobbel
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Struct#8336Rationale for this change
While pathfinding variant unshredding code, I noticed that there's a lot of variant metadata cloning going on. It's a 32-byte object, so cloning is not free. And it turns out that ~all read-only metadata builder usage in the code base can work just as easily with a borrowed reference because ultimately we're working with bytes borrowed from a binary view that holds the metadata column.
What changes are included in this PR?
Update the
ReadOnlyMetadataBuilderto borrow theVariantMetadatait uses, and update call sites accordingly.Are these changes tested?
Yes, the change affects several unit tests.
Are there any user-facing changes?
Signature of
ReadOnlyMetadataBuilder::newhas changed.